Skip to content

Add Certificate Request for OpenBuild#1023

Merged
mgallien merged 1 commit into
nextcloud:masterfrom
rjzondervan:rjzondervan-patch-3
Jun 4, 2026
Merged

Add Certificate Request for OpenBuild#1023
mgallien merged 1 commit into
nextcloud:masterfrom
rjzondervan:rjzondervan-patch-3

Conversation

@rjzondervan

Copy link
Copy Markdown
Contributor

Signed-off-by: Robert Zondervan <robert@conduction.nl>

@mgallien mgallien left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjzondervan the app id between the app id in your repository and the one in the app certificate requests are different
you have openbuilt in the app itself while the request if about openbuild
can you check and fix ?

@rjzondervan

rjzondervan commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

@mgallien Thanks for noticing, we had just renamed the app (it was incorrectly labeled openbuilt). The app id should now have been updated on the repository.

@mgallien

mgallien commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@mgallien Thanks for noticing, we had just renamed the app (it was incorrectly labeled openbuilt). The app id should now have been updated on the repository.

for now, I still see the wrong app ID (https://codeberg.org/Conduction/openbuild/src/branch/beta/appinfo/info.xml#L4)
if I generate the certificate for you, it will not work as long as it differ from the app's id

@rjzondervan

Copy link
Copy Markdown
Contributor Author

Hi @mgallien,
Ah, you are also looking at the beta branch. I rolled the change of the app id down to that branch also, and will notify everyone working on the repository to merge this branch in their open branches.
As said, we have changed the name of this app shortly before creating the PR, and the person who did the name change on the repo did this less thoroughly than I was told.

@mgallien

mgallien commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Hi @mgallien, Ah, you are also looking at the beta branch. I rolled the change of the app id down to that branch also, and will notify everyone working on the repository to merge this branch in their open branches. As said, we have changed the name of this app shortly before creating the PR, and the person who did the name change on the repo did this less thoroughly than I was told.

missed that was in a specific branch (if I get it, this is the default one)

mgallien added a commit that referenced this pull request Jun 4, 2026
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien merged commit a8728f5 into nextcloud:master Jun 4, 2026
3 checks passed
@mgallien

mgallien commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@rjzondervan Your crt file: 3656d4a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants